Prevent RuntimeError while reinitializing clusters - sync and async #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #3565 by preventing runtime errors when reinitializing clusters in both synchronous and asynchronous modes. The changes ensure safe iteration over startup nodes by converting the dictionary values to a tuple.
- Changed iteration in redis/cluster.py to iterate over a tuple of startup nodes.
- Changed iteration in redis/asyncio/cluster.py similarly to avoid runtime errors.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| redis/cluster.py | Iteration over startup_nodes now uses tuple conversion to avoid runtime errors during reinitialization. |
| redis/asyncio/cluster.py | Similar tuple conversion applied for asynchronous startup_nodes iteration. |
vladvildanov
approved these changes
May 8, 2025
petyaslavova
deleted the
ps_fix_runtime_error_during_cluster_initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fix for issue #3565
Thanks to @jakob-keller